https://bugzilla.redhat.com/show_bug.cgi?id=1894911
Jitka Plesnikova <jples...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova <jples...@redhat.com> ---
Source file is ok
Summary is ok
License
FIX: Please check the license text in files
* PDF-Builder-3.019/lib/PDF/Builder/Basic/PDF/*.pm
They contains:
# THIS IS A REUSED PERL MODULE, FOR PROPER LICENCING TERMS SEE BELOW:
#
# Copyright Martin Hosken <martin_hos...@sil.org>
#
# No warranty or expression of effectiveness, least of all regarding
# anyone's safety, is implied in this software or documentation.
#
# This specific module is licensed under the Perl Artistic License.
* PDF-Builder-3.019/lib/PDF/Builder/Matrix.pm
# This library is free software; you can redistribute it
# and/or modify it under the same terms as Perl itself.
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
$ rpm -qp --requires perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c
| grep -v rpmlib | grep -v PDF::Builder
1 perl(base)
1 perl(Carp)
1 perl(Compress::Zlib) >= 1
1 perl(constant)
1 perl(Encode)
1 perl(Exporter)
1 perl(File::Basename)
1 perl(FileHandle)
1 perl(File::Temp)
1 perl(Font::TTF::Font)
1 perl(IO::File)
1 perl(List::Util)
1 perl(Math::Trig)
1 perl(:MODULE_COMPAT_5.32.0)
1 perl(POSIX)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(Unicode::UCD)
1 perl(vars)
1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --provides perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c
I do not add long list of all provides. Binary provides are Ok.
$ rpmlint ./perl-PDF-Builder*
perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-PDF-Builder/examples/resources/pod2htmd.temp
perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/perl-PDF-Builder/examples/resources/sample.txt
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
FIX: Could it be fix? Or are the files valid examples?
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct 'FIX' items.
Resolution:
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
