https://bugzilla.redhat.com/show_bug.cgi?id=1891370



--- Comment #2 from Robert Scheck <redhat-bugzi...@linuxnetz.de> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
> unrealircd.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/unrealircd
> ['/builddir/unrealircd/lib']

Fixed.

>  - The program reeds to use Fedora default SSL crypto:
> 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/

Fixed as suggested by bullet #1 by patching the default configuration.

>  - Please include this licensese and add a comment explaining the license
> breakdown:

Fixed, but IMHO the "Expat License" is effectively "MIT", especially as the
"Expat License" is not mentioned at
https://fedoraproject.org/wiki/Licensing:Main

>  - Please add a comment above each patch explaining why they are needed.

Fixed.

>  - Don't mix tabs and spaces, lire 15 there is a tab

Fixed.


Spec URL: http://labs.linuxnetz.de/bugzilla/unrealircd.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/unrealircd-5.0.7-2.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to