https://bugzilla.redhat.com/show_bug.cgi?id=1895766
Nathan Scott <nath...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|If docs needed, set a value |No Doc Update
Flags|needinfo?(nath...@redhat.co |
|m) |
Red Hat Bugzilla <bugzi...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|No Doc Update |No Doc Update
--- Comment #3 from Nathan Scott <nath...@redhat.com> ---
> - I'm not 100% sure if the .galaxy_install_info files should be there in
> every role/meta folder - it contains an "install_date" and a version which is
> set to "0.0.1" (which doesn't match the package version). Can you verify if
> this file should be in the RPM?
This is a historical quirk - they should not exist even in the git repo
anymore, I'll fix that and do a 2.0.3 before uploading.
> - It would be great if tests run as part of the %check, but I assume that's
> not possible due to the nature of the package? I.e. it would require a VM or
> container to perform tests of the ansible roles?
For realistic testing we'd need to make invasive change to the build machine or
use a VM, yeah. I can't think of anything meaningful we can add here in
practice that's going to be helpful above and beyond the existing CI.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
