https://bugzilla.redhat.com/show_bug.cgi?id=1905189



--- Comment #1 from Miro HronĨok <mhron...@redhat.com> ---
Spec sanity:

> %{?python_provide:%python_provide python3-%{pypi_name}}

If you only target F33+, you can drop it. If you also target F32, please use
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_the_py_provides_macro
instead.



> %description -n python3-%{pypi_name}
> ${summary}

That seems like a typo (note the $).



> %{python3_sitelib}/%{pypi_name}
> %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info

I recommend adding training slashes to indicate and assert those are
directories.


Running Fedora Review.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to