https://bugzilla.redhat.com/show_bug.cgi?id=1919688



--- Comment #6 from Ville-Pekka Vainio <vpvai...@iki.fi> ---
Updated spec: https://vpv.fedorapeople.org/packages/voikko-fi.spec
Updated SRPM:
https://vpv.fedorapeople.org/packages/voikko-fi-2.4-3.fc33.src.rpm

(In reply to Miro Hrončok from comment #4)
> You don technically need python3-devel (as I've tried to already say in my
> initial comment), but it makes our (Python maintainers) queries easier.
> However, if you are strictly against this, I won't fight you.

In that case I'm willing to BuildRequire python3-devel.

> Are there (even theoretically) other packages that will install into that
> directory? If yes, I'd transfer the ownership to the lib.

I'll aim to answer all of your questions here.

Yes, there could be other packages installing into that directory, at least in
theory.

The number 5 in /usr/lib/voikko/5 is a dictionary format ID. It means it's the
VFST (Varissuo Finite State Transducer) format, which is apparently a custom
format developed by the Voikko project.
As this package (voikko-fi) implements format 5, the directory named 5 should
definitely be owned by this package.

There is also format 3, HFST (Helsinki Finite State Transducer), which is
developed by the University of Helsinki. Those data files would go under the
directory named 3 and could be provided by other packages.
The HFST format supports languages other than Finnish. Apparently at least
North Sámi, Lule Sámi and South Sámi are supported, but I'm not yet familiar
with these options.
Supporting the HFST format requires hfst-ospell as a libvoikko dependency and
that package is not yet in Fedora. I might add HFST support and maybe even some
language files in the future, but I'd need to ask on the upstream mailing lists
if anyone would actually use them on Fedora. I also don't yet know whether the
licences of the language data for the different Sámi languages allow them to be
shipped in Fedora.

From what I understand, mor-standard means "standard Finnish morphology". You
could for example make a special morphology for Sukija by running "make
vvfst-sukija" and apparently that would go under mor-sukija. Sukija a solr
plugin for indexing Finnish texts (https://github.com/ahomansikka/sukija), but
it's not in Fedora. That directory would also be provided by this package,
probably in a sub-package, if someone wanted to contribute that stuff.

By the way, do I still need to %dir in Fedora?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to