https://bugzilla.redhat.com/show_bug.cgi?id=1895567
--- Comment #14 from c...@musicinmybrain.net --- I’m not quite ready to commit to being the reviewer for this package. Please consider this a “preliminary review” in advance of review by myself or by someone else. There’s a lot going on in this package, and there is room for me to have missed, or to be wrong about, something below, or for reasonable disagreement about any number of details. - Reported by fedora-review: Header files in -devel subpackage, if present. Note: usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd : /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd- libs : /usr/lib64/usd/usd/resources/codegenTemplates/api.h usd-libs : /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.h usd-libs : /usr/lib64/usd/usd/resources/codegenTemplates/tokens.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages The examples are certainly okay, and the others are used as templates for code generation, so I think this is fine. - The shared libraries do not have SONAMEs set; the unversioned .so files packaged in -devel are the actual libraries that should be in -libs, and there are no libraries in -libs at all! There was some previous discussion of this, but I am still not convinced this is right. These libraries correspond to the headers in -devel; if those are public headers then these are public libraries and should be installed in -libs. And in that case, they need so-versions and symlinks. At least, that’s how it seems. - Bundled libraries must be handled according to https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling. * pxr/base/tf/pxrLZ4/ contains a bundled copy of https://github.com/lz4/lz4, which is the lz4 package in Fedora. Pixar has forked it by “C++-ifying” it (adding namespaces and removing C linkage). Reading the lz4 version number out of lz4.h, you need to add Provides: bundled(lz4) = 1.9.2 Then you are required to publicly contact upstream (e.g. by GitHub issue) about a path to supporting system libraries. If upstream refuses, this must be recorded in the spec file, either in comments placed adjacent to the Provides: above, or in an additional file checked into the SCM and referenced by a comment placed adjacent to the Provides: above. * pxr/base/js/rapidjson/ is a bundled copy of https://github.com/Tencent/rapidjson. Again, figure out how to unbundle it or contact upstream and add (reading the version from pxr/base/js/rapidjson/rapidjson.h): Provides: bundled(rapidjson) = 1.0.2 * pxr/base/tf/pxrDoubleConversion/ is a bundled copy of https://github.com/google/double-conversion, forked with namespace patches. Contact upstream and add: Provides: bundled(double-conversion) = 2.0.0 * These: pxr/base/gf/ilmbase_eLut.h pxr/base/gf/ilmbase_half.cpp pxr/base/gf/ilmbase_half.h pxr/base/gf/ilmbase_halfLimits.h pxr/base/gf/ilmbase_half.patch pxr/base/gf/ilmbase_half.README pxr/base/gf/ilmbase_toFloat.h are bundled from the ilmbase part of OpenEXR, https://github.com/AcademySoftwareFoundation/openexr/. Reading the version from the README, contact upstream and add: Provides: bundled(ilmbase) = 2.5.3 * third_party/renderman-23/plugin/rmanArgsParser/pugixml/ is a bundled copy of https://github.com/zeux/pugixml/; contact upstream and add Provides: bundled(pugixml) = 1.9 * pxr/base/tf/pyLock.cpp contains code from https://github.com/pankajp/pygilstate_check, but it is only a handful of lines, and it hardly seems we should track it as a bundled library. * pxr/imaging/hio/stb contains three bundled and patched libraries, https://github.com/nothings/stb/blob/master/stb_image.h, https://github.com/nothings/stb/blob/master/stb_image_write.h, and https://github.com/nothings/stb/blob/master/stb_image_resize.h. Contact upstream and add: Provides: bundled(stb_image) = 2.19 Provides: bundled(stb_image_resize) = 0.95 Provides: bundled(stb_image_write) = 1.09 * LICENSE.txt credits “Vulkan C++ examples and demos (dome light texture filtering)”, but I cannot find which source files are relevant. * LICENSE.txt credits “pbrt (Hammersley Low-Discrepancy Sampling Sequence)”, which refers to https://pbrt.org/, but there does not appear to be any obvious actual bundling. * LICENSE.txt claims USD bundles https://github.com/google/draco, but in fact the optional Draco plugin builds against an external Draco. * pxr/imaging/hgiVulkan/vk_mem_alloc.h is a bundled copy of https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator. Contact upstream and add: Provides: bundled(VulkanMemoryAllocator) = 3.0.0~development * pxr/imaging/hgiVulkan/spirv_reflect.h and pxr/imaging/hgiVulkan/spirv_reflect.cpp are a bundled copy of https://github.com/KhronosGroup/SPIRV-Reflect. Contact upstream and add Provides: bundled(SPIRV-Reflect) = 1.0 Make sure to update the versions on any virtual Provides when you update the overall package. - There are parts of the package with license other than the overall license of ASL 2.0; you must follow https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios, updating the License field and providing a breakdown of licensing. See the linked guidelines section for three ways to do this. Note that even the main LICENSE.txt describes components under multiple licenses. The overall license appears to be ASL 2.0 and BSD and MIT and (MIT or Unlicense) as broken down in the following. * While licensecheck detect GPLv3+ in USD-21.02/pxr/usd/sdf/path.tab.cpp USD-21.02/pxr/usd/sdf/path.tab.h USD-21.02/pxr/usd/sdf/textFileFormat.tab.cpp USD-21.02/pxr/usd/sdf/textFileFormat.tab.h USD-21.02/third_party/renderman-23/plugin/hdPrman/virtualStructConditionalGrammar.tab.cpp USD-21.02/third_party/renderman-23/plugin/hdPrman/virtualStructConditionalGrammar.tab.h the exception /* As a special exception, you may create a larger work that contains part or all of the Bison parser skeleton and distribute that work under terms of your choice, so long as that work isn't itself a parser generator using the skeleton or a modified version thereof as a parser skeleton. Alternatively, if you modify or redistribute the parser skeleton itself, you may (at your option) remove this special exception, which will cause the skeleton and the resulting Bison output files to be licensed under the GNU General Public License without this special exception. This special exception was added by the Free Software Foundation in version 2.2 of Bison. */ applies and therefore only the ASL 2.0 license in the first license header is relevant. See https://lists.fedoraproject.org/archives/list/le...@lists.fedoraproject.org/thread/E7RRI4KTODK3QS4XI7KJH4P2RT4FJNB3/ for confirmation. * The bundled pxr/base/tf/pxrLZ4/, mentioned in the previous issue, is BSD-licensed. * Most of the bundled pxr/base/js/rapidjson/, mentioned in the previous issue, is MIT-licensed, except pxr/base/js/rapidjson/msinttypes/ which are BSD-licensed (albeit Visual Studio-specific). (It does not include the bin/jsonchecker code that would be under the nonfree JSON License, which is good.) * The bundled pxr/base/tf/pxrDoubleConversion/, mentioned in the previous issue, is BSD-licensed. * The bundled pxr/base/gf/ilmbase_*, mentioned in the previous issue, is BSD-licensed. * cmake/modules/FindTBB.cmake is MIT-licensed, but only used to control the build and therefore does not contribute to the built RPM license * third_party/renderman-23/plugin/rmanArgsParser/pugixml/ is MIT-licensed * pxr/base/tf/pyLock.cpp is ASL 2.0 but the code after // See https://github.com/pankajp/pygilstate_check is MIT. * pxr/imaging/garch/khrplatform.h is labeled “Khronos License” by licensecheck, but it is just MIT * pxr/imaging/hio/stb/ is MIT or Unlicense * pxr/base/arch/debugger.cpp contains an AmIBeingDebugged() function from https://developer.apple.com/library/content/qa/qa1361/_index.html under a license given in the top-level LICENSE.txt. It looks open-source but I do not recognize it. Normally we would need to email le...@lists.fedoraproject.org for an opinion (and a license name if it is a new acceptable license) but since this code is only compiled on Darwin platforms it does not affect the overall license field on Fedora and I think we can skip this exercise. * pxr/imaging/hgiVulkan/vk_mem_alloc.h is MIT - Are you intending to build python3-usd? Why is the build conditional currently off? Note that this provides a lot more than usdview; it is also required for quite a few command-line tools. I tried it and the build bailed out with -- Found PySide2 but NOT pyside-uic binary CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message): Could NOT find PySide (missing: PYSIDE_AVAILABLE) Call Stack (most recent call first): /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE) cmake/modules/FindPySide.cmake:75 (find_package_handle_standard_args) cmake/defaults/Packages.cmake:273 (find_package) CMakeLists.txt:23 (include) but this is fixable; see https://bugzilla.redhat.com/show_bug.cgi?id=1882270. You can just change -DPYSIDEUICBINARY="%{_bindir}/pyside2-uic" \ to -DPYSIDEUICBINARY="%{_bindir}/uic-qt5" \ and add BuildRequires: qt5-qtbase-devel to the Python subpackage. Of course, once you have a GUI application (usdview is one, I think?) you will need a .desktop file https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files and AppData https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/. Furthermore, it seems like the installation of the Python packages is really, really broken when I try to enable it, so I guess there would be more work needed if the Python parts were to be packaged. - Does the documentation build easily if you set PXR_BUILD_DOCUMENTATION=TRUE and add BR’s on doxygen and graphviz? A real -doc subpackage with full documentation would be a nice addition. - Above the ExclusiveArch, please try to explain in a little more detail why the package must be x86_64-only. I agree that this looks like it is the case. Once the package is approved, you must create Bugzilla bugs blocking the various ExcludeArch tracker bugs, even if you close them immediately as WONTFIX. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures. - Please change Requires: %{name}%{?_isa} = %{version} to Requires: %{name}%{?_isa} = %{version}-%{release} See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package. Note also that the -devel package should really require Requires: %{name}-libs%{?_isa} = %{version}-%{release} instead, and perhaps the base package should as well. - There is no %check section; did you try building the tests? - Please remove # Explicity define python macro to avoid unversioned python %define __python /usr/bin/python3 because nothing should be using an unversioned %__python. (Also, prefer %global to %define.) Also, change BuildRequires: python-rpm-macros to BuildRequires: python3-devel and replace %{python_sitearch} with %{python3_sitearch}, which together fix the reason you wanted an unversioned %__python in the first place. - Is Python really found using pkg-config? Maybe just drop this? BuildRequires: pkgconfig(python3) - Note that you can use (but are not required to use) https://src.fedoraproject.org/rpms/pyproject-rpm-macros to get automatically generated Python BR’s. - Please convert NOTICE.txt from CRNL line encoding. Add BuildRequires: dos2unix and in %prep, dos2unix NOTICE.txt - Please add find %{buildroot}%{_datadir}/%{name}/examples -name '*.so' -print -delete or just rm %{buildroot}%{_datadir}/%{name}/examples/plugin/hdTiny.so to remove /usr/share/usd/examples/plugin/hdTiny.so because there should not be arch-specific code in /usr/share. - Please fix mixed tabs and spaces in spec file, e.g. sed -r -i 's/\t/ /g' usd.spec ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. See Issues. These are real libraries, not symlinks, and it is not clear that they are correctly handled. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Khronos License Expat License Apache License 2.0", "Apache License 2.0", "Expat License", "BSD 3-clause "New" or "Revised" License", "Apache License 2.0 [generated file]", "Khronos License", "Apache License 2.0 GNU General Public License v3.0 or later", "BSD 2-clause "Simplified" License", "the Unlicense Expat License", "*No copyright* Apache License 2.0". 2550 files have unknown license. Detailed output of licensecheck in /home/reviewer/1895567-usd/20210205/1895567-usd/licensecheck.txt Multiple licenses; see Issues above. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. As far as I can tell... [!]: Package contains no bundled libraries without FPC exception. FPC exception no longer required per https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling, but guidelines must be followed. See Issues for details. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. Follow https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures. See Issues. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 245760 bytes in 7 files. OK unless you start building more documentation. [x]: Package complies to the Packaging Guidelines (except as noted) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in usd-libs , usd-devel Need -%{release}; -devel should require -libs, and maybe the base package should too. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define __python /usr/bin/python3 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: usd-21.02-3.fc34.x86_64.rpm usd-libs-21.02-3.fc34.x86_64.rpm usd-devel-21.02-3.fc34.x86_64.rpm usd-debuginfo-21.02-3.fc34.x86_64.rpm usd-debugsource-21.02-3.fc34.x86_64.rpm usd-21.02-3.fc34.src.rpm usd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/usd/examples/plugin/hdTiny.so usd.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd/NOTICE.txt usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd.x86_64: W: no-manual-page-for-binary sdfdump usd.x86_64: W: no-manual-page-for-binary sdffilter usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/api.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapSchemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapTokens.cpp usd-libs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd-libs/NOTICE.txt usd-devel.x86_64: E: invalid-soname /usr/lib64/libar.so libar.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libarch.so libarch.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libcameraUtil.so libcameraUtil.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libgarch.so libgarch.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libgarch.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libgf.so libgf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libglf.so libglf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhd.so libhd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdSt.so libhdSt.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdx.so libhdx.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhf.so libhf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgi.so libhgi.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiGL.so libhgiGL.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiInterop.so libhgiInterop.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhio.so libhio.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libjs.so libjs.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libkind.so libkind.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libndr.so libndr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpcp.so libpcp.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libplug.so libplug.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpxOsd.so libpxOsd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdf.so libsdf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdf.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdr.so libsdr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libtf.so libtf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so exit@GLIBC_2.2.5 usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so _exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libtrace.so libtrace.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusd.so libusd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdAppUtils.so libusdAppUtils.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdGeom.so libusdGeom.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdHydra.so libusdHydra.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdImaging.so libusdImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdImagingGL.so libusdImagingGL.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdLux.so libusdLux.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdMedia.so libusdMedia.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRender.so libusdRender.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRi.so libusdRi.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRiImaging.so libusdRiImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdShade.so libusdShade.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdSkel.so libusdSkel.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdSkelImaging.so libusdSkelImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdUI.so libusdUI.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdUtils.so libusdUtils.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdVol.so libusdVol.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdVolImaging.so libusdVolImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libvt.so libvt.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libwork.so libwork.so usd.src:5: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 5) 6 packages and 0 specfiles checked; 45 errors, 20 warnings. Rpmlint (debuginfo) ------------------- Checking: usd-debuginfo-21.02-3.fc34.x86_64.rpm usd-devel-debuginfo-21.02-3.fc34.x86_64.rpm usd-libs-debuginfo-21.02-3.fc34.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/api.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapSchemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapTokens.cpp usd-libs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd-libs/NOTICE.txt usd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/usd/examples/plugin/hdTiny.so usd.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd/NOTICE.txt usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd.x86_64: W: no-manual-page-for-binary sdfdump usd.x86_64: W: no-manual-page-for-binary sdffilter usd-devel.x86_64: E: invalid-soname /usr/lib64/libar.so libar.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libarch.so libarch.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libcameraUtil.so libcameraUtil.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libgarch.so libgarch.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libgarch.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libgf.so libgf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libglf.so libglf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhd.so libhd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdSt.so libhdSt.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdx.so libhdx.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhf.so libhf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgi.so libhgi.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiGL.so libhgiGL.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiInterop.so libhgiInterop.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhio.so libhio.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libjs.so libjs.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libkind.so libkind.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libndr.so libndr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpcp.so libpcp.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libplug.so libplug.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpxOsd.so libpxOsd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdf.so libsdf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdf.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdr.so libsdr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libtf.so libtf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so exit@GLIBC_2.2.5 usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so _exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libtrace.so libtrace.so Rpmlint (installed packages) ---------------------------- usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/api.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/schemaClass.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/tokens.h usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapSchemaClass.cpp usd-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/usd/usd/resources/codegenTemplates/wrapTokens.cpp usd-libs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd-libs/NOTICE.txt usd.x86_64: E: arch-dependent-file-in-usr-share /usr/share/usd/examples/plugin/hdTiny.so usd.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/usd/NOTICE.txt usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/mesh.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderDelegate.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/renderPass.h usd.x86_64: W: devel-file-in-non-devel-package /usr/share/usd/examples/include/pxr/imaging/hdTiny/rendererPlugin.h usd.x86_64: W: no-manual-page-for-binary sdfdump usd.x86_64: W: no-manual-page-for-binary sdffilter usd-devel.x86_64: E: invalid-soname /usr/lib64/libar.so libar.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libarch.so libarch.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libcameraUtil.so libcameraUtil.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libgarch.so libgarch.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libgarch.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libgf.so libgf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libglf.so libglf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhd.so libhd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdSt.so libhdSt.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhdx.so libhdx.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhf.so libhf.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgi.so libhgi.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiGL.so libhgiGL.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhgiInterop.so libhgiInterop.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libhio.so libhio.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libjs.so libjs.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libkind.so libkind.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libndr.so libndr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpcp.so libpcp.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libplug.so libplug.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libpxOsd.so libpxOsd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdf.so libsdf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libsdf.so exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libsdr.so libsdr.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libtf.so libtf.so usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so exit@GLIBC_2.2.5 usd-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libtf.so _exit@GLIBC_2.2.5 usd-devel.x86_64: E: invalid-soname /usr/lib64/libtrace.so libtrace.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusd.so libusd.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdAppUtils.so libusdAppUtils.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdGeom.so libusdGeom.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdHydra.so libusdHydra.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdImaging.so libusdImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdImagingGL.so libusdImagingGL.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdLux.so libusdLux.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdMedia.so libusdMedia.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRender.so libusdRender.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRi.so libusdRi.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdRiImaging.so libusdRiImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdShade.so libusdShade.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdSkel.so libusdSkel.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdSkelImaging.so libusdSkelImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdUI.so libusdUI.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdUtils.so libusdUtils.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdVol.so libusdVol.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libusdVolImaging.so libusdVolImaging.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libvt.so libvt.so usd-devel.x86_64: E: invalid-soname /usr/lib64/libwork.so libwork.so 7 packages and 0 specfiles checked; 45 errors, 19 warnings. Unversioned so-files -------------------- usd: /usr/share/usd/examples/plugin/hdTiny.so usd-libs: /usr/lib64/usd/plugin/hdEmbree.so usd-libs: /usr/lib64/usd/plugin/hdStorm.so usd-libs: /usr/lib64/usd/plugin/hioOiio.so usd-libs: /usr/lib64/usd/plugin/sdrGlslfx.so usd-libs: /usr/lib64/usd/plugin/sdrOsl.so usd-libs: /usr/lib64/usd/plugin/usdAbc.so usd-libs: /usr/lib64/usd/plugin/usdShaders.so Source checksums ---------------- https://github.com/PixarAnimationStudios/usd/archive/v21.02/usd-21.02.tar.gz : CHECKSUM(SHA256) this package : 97bbae5d86d6e4db357645db183be03afe28fe024b242f27bd4f62b4e2eade53 CHECKSUM(SHA256) upstream package : 97bbae5d86d6e4db357645db183be03afe28fe024b242f27bd4f62b4e2eade53 Requires -------- usd (rpmlib, GLIBC filtered): libarch.so()(64bit) libboost_program_options.so.1.75.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhd.so()(64bit) libhf.so()(64bit) libsdf.so()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtf.so()(64bit) libvt.so()(64bit) rtld(GNU_HASH) usd-libs (rpmlib, GLIBC filtered): libAlembic.so.1.7()(64bit) libHalf-2_5.so.25()(64bit) libOpenImageIO.so.2.2()(64bit) libar.so()(64bit) libarch.so()(64bit) libc.so.6()(64bit) libcameraUtil.so()(64bit) libembree3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgf.so()(64bit) libhd.so()(64bit) libhdSt.so()(64bit) libhf.so()(64bit) libhio.so()(64bit) libm.so.6()(64bit) libndr.so()(64bit) liboslquery.so.1.11()(64bit) libplug.so()(64bit) libpthread.so.0()(64bit) libpxOsd.so()(64bit) libsdf.so()(64bit) libsdr.so()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.2()(64bit) libtf.so()(64bit) libtrace.so()(64bit) libusd.so()(64bit) libusdGeom.so()(64bit) libusdShade.so()(64bit) libvt.so()(64bit) libwork.so()(64bit) rtld(GNU_HASH) usd-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) ld-linux-x86-64.so.2()(64bit) libGL.so.1()(64bit) libHalf-2_5.so.25()(64bit) libOpenColorIO.so.1()(64bit) libX11.so.6()(64bit) libar.so()(64bit) libarch.so()(64bit) libc.so.6()(64bit) libcameraUtil.so()(64bit) libdl.so.2()(64bit) libgarch.so()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgf.so()(64bit) libglf.so()(64bit) libhd.so()(64bit) libhdSt.so()(64bit) libhdx.so()(64bit) libhf.so()(64bit) libhgi.so()(64bit) libhgiGL.so()(64bit) libhgiInterop.so()(64bit) libhio.so()(64bit) libjemalloc.so.2()(64bit) libjs.so()(64bit) libkind.so()(64bit) libm.so.6()(64bit) libndr.so()(64bit) libopenvdb.so.8.0()(64bit) libosdCPU.so.3.4.3()(64bit) libosdGPU.so.3.4.3()(64bit) libpcp.so()(64bit) libplug.so()(64bit) libpthread.so.0()(64bit) libpxOsd.so()(64bit) libsdf.so()(64bit) libsdr.so()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtbb.so.2()(64bit) libtf.so()(64bit) libtrace.so()(64bit) libusd.so()(64bit) libusdGeom.so()(64bit) libusdImaging.so()(64bit) libusdImagingGL.so()(64bit) libusdLux.so()(64bit) libusdShade.so()(64bit) libusdSkel.so()(64bit) libusdVol.so()(64bit) libvt.so()(64bit) libwork.so()(64bit) rtld(GNU_HASH) usd(x86-64) usd-debuginfo (rpmlib, GLIBC filtered): usd-debugsource (rpmlib, GLIBC filtered): Provides -------- usd: usd usd(x86-64) usd-libs: usd-libs usd-libs(x86-64) usd-devel: cmake(pxr) libar.so()(64bit) libarch.so()(64bit) libcameraUtil.so()(64bit) libgarch.so()(64bit) libgf.so()(64bit) libglf.so()(64bit) libhd.so()(64bit) libhdSt.so()(64bit) libhdx.so()(64bit) libhf.so()(64bit) libhgi.so()(64bit) libhgiGL.so()(64bit) libhgiInterop.so()(64bit) libhio.so()(64bit) libjs.so()(64bit) libkind.so()(64bit) libndr.so()(64bit) libpcp.so()(64bit) libplug.so()(64bit) libpxOsd.so()(64bit) libsdf.so()(64bit) libsdr.so()(64bit) libtf.so()(64bit) libtrace.so()(64bit) libusd.so()(64bit) libusdAppUtils.so()(64bit) libusdGeom.so()(64bit) libusdHydra.so()(64bit) libusdImaging.so()(64bit) libusdImagingGL.so()(64bit) libusdLux.so()(64bit) libusdMedia.so()(64bit) libusdRender.so()(64bit) libusdRi.so()(64bit) libusdRiImaging.so()(64bit) libusdShade.so()(64bit) libusdSkel.so()(64bit) libusdSkelImaging.so()(64bit) libusdUI.so()(64bit) libusdUtils.so()(64bit) libusdVol.so()(64bit) libusdVolImaging.so()(64bit) libvt.so()(64bit) libwork.so()(64bit) usd-devel usd-devel(x86-64) usd-debuginfo: debuginfo(build-id) usd-debuginfo usd-debuginfo(x86-64) usd-debugsource: usd-debugsource usd-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1895567 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, SugarActivity, Ruby, fonts, Python, Java, Perl, R, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
