https://bugzilla.redhat.com/show_bug.cgi?id=1910860

Robert-André Mauchin 🐧 <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #2 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
(In reply to Elliott Sales de Andrade from comment #1)
> If you want v3, this should be named golang-github-cheggaaa-pb-3, and you
> should use github.com/cheggaaa/pb/v3 as import path.

This but also, due to how this package is made, with a v3 subdirectory, you
should do something like this in %prep:

# https://github.com/cheggaaa/pb
%global goipath         github.com/cheggaaa/pb/v3
%global forgeurl        https://github.com/cheggaaa/pb

[…]

%prep
%goprep
rm *.go && mv v3/* ./


Otherwise it could create conflicts if a dependency chain both depend on v1 and
v3. This way we have the correct import path (github.com/cheggaaa/pb/v3) and
the correct location for the .goipath file.

Needinfo me for review once fixed.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to