https://bugzilla.redhat.com/show_bug.cgi?id=1933988
c...@musicinmybrain.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #17 from c...@musicinmybrain.net ---
I’m not sure that requiring all of CMake from -devel to own the directory is
the right approach. Is the goal to support EPEL7, where this package is not
available? If so, it seems like it would be better to conditionalize it:
%if 0%{?epel} == 7
Requires: cmake%{?_isa}
%else
Requires: cmake-filesystem
%endif
Actually, what I would do is
%if 0%{?epel} != 7
Requires: cmake-filesystem
%endif
and then in %files devel, co-own the directory on EPEL7:
%if 0%{?epel} == 7
%dir %{_libdir}/cmake/
%endif
----
That said, I’ll go ahead and approve the package as-is. Thanks for working
through all of these details.
----
If you have the chance to review one of mine, would you mind doing
https://bugzilla.redhat.com/show_bug.cgi?id=1936138? I need it for unbundling
from grpc. It’s a header-only C library that shouldn’t take long to review.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
