https://bugzilla.redhat.com/show_bug.cgi?id=1932728
Aleksei Bavshin <alebast...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(alebastr89@gmail. |
|com) |
--- Comment #4 from Aleksei Bavshin <alebast...@gmail.com> ---
(In reply to Davide Cavalca from comment #3)
> Outstanding issues:
> - no package is owning /etc/sway/config.d; this should be owned either by
> this package, or by sway itself if it's a generic sway thing that others may
> drop configs into
Will be owned by sway, see
https://src.fedoraproject.org/rpms/sway/pull-request/11
> - missing scriptlets for systemd user units (see
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/
> #_user_units)
I checked other specs and I've never seen this part of the guildelines being
applied to target files (see gnome-session and plasma-workspace).
I'm not opposed to adding the scriptlets though, just not sure if those will do
anything meaningful.
> Also, the specfile lists this under MIT, but licensecheck detects it an
> Expat license (although it is actually MIT afaict). It'd be good to add
> license headers to the upstream sources as well, but it's not a blocker.
The commonly used MIT variant is the same as Expat license. Licensecheck is
either not aware of that or uses Expat to avoid ambiguity with MIT/X11 and
other variants.
AFAIK, license headers are not required and certainly won't affect licensecheck
output.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
