https://bugzilla.redhat.com/show_bug.cgi?id=1922315



--- Comment #7 from Davide Cavalca <dcava...@fb.com> ---
Thank you all for the review and comments!

- yes, the last tagged release is ancient and doesn't build properly, so
packaging tip is best here. 
- I'm packaging the static libraries because folly doesn't have a stable ABI,
we do this for all libraries that depend on folly. See #1887621 for a
discussion on that
- I tried reenabling the tests but I still get spurious failures about half of
the time, so I'm inclined to keep them off for now, at least until I can figure
out how to make them more reliable
- how do I add a waiver for rpmlint?
- the exit() comes from TransferLogManager::checkLog(); I agree that this
should be fixed if possible, I'll follow up with upstream to see what we can do
about that


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to