https://bugzilla.redhat.com/show_bug.cgi?id=1929992
--- Comment #10 from Karolina Surma <ksu...@redhat.com> --- The package can be approved. Suggestions: 1) Explicit Requires is not necessary, it is generated automatically. You can remove the line: Requires: python3dist(bracex) >= 2.1.1 2) You can use %pytest macro (replace "%python3 -m pytest") It is maintained and ensures that future updates will work as expected. It also provides some additional features, eg. tests everything that is installed, while direct call tests current working directory. 3) It is better to skip the one failing test instead of the whole test file. Current results of check: ======================= 859 passed, 64 skipped in 2.77s ======================== If used command: %pytest -vv -k "not test_tilde_user" =============== 1141 passed, 148 skipped, 1 deselected in 2.65s ================ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
