Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=661660 --- Comment #5 from Mohamed El Morabity <pikachu.2...@gmail.com> 2010-12-20 10:18:34 EST --- * Since wxGTK is already required by wxPython, you don't need to set wxGTK as a Requires. But python-mutagen is required for multimedia tags support; please add it as Requires. * The following files: - src/operations/greek_numb.py src/EXIF.py - src/mutagen/__init__.py are only used as libraries in metamorphose2, so: - they must not be executable - their shebang must be removed. See: http://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Remove_shebang_from_Python_libraries * You should not add the .gz extension to man pages listed in %files, you'd rather use the "*" joker: %files -f %{name}.lang %defattr(-,root,root,-) [...] %{_mandir}/man1/%{name}.1.* [...] * gettext as BR is not really needed here, it is never called by the build tools. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
