Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663956 Jussi Lehtola <jussi.leht...@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.leht...@iki.fi --- Comment #1 from Jussi Lehtola <jussi.leht...@iki.fi> 2010-12-20 10:56:59 EST --- Please get rid of the Mandriva stuff: %define name python-%{module} Name: %{name} is just silly. If you want to use the %{module} definition for something, then just do Name: python-%{module} *** Drop %if ! (0%{?fedora} > 12 || 0%{?rhel} > 5) %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())")} %endif as you don't use it anywhere. *** The build system looks a bit odd, since it doesn't print out the command used to compile the object file: compiling C sources C compiler: gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -D_GNU_SOURCE -fPIC -fwrapv -fPIC creating build/temp.linux-x86_64-2.7 creating build/temp.linux-x86_64-2.7/numexpr compile options: '-I/usr/lib64/python2.7/site-packages/numpy/core/include -I/usr/include/python2.7 -c' extra options: '-funroll-all-loops' gcc: numexpr/interpreter.c gcc -pthread -shared build/temp.linux-x86_64-2.7/numexpr/interpreter.o -L/usr/lib64 -lpython2.7 -o build/lib.linux-x86_64-2.7/numexpr/interpreter.so running scons + exit 0 *** There's no need to use macros for standard commands, although this is not disallowed in the guidelines. ** Please use the standard install command from the Python guidelines python setup.py install -O1 --skip-build --root %{buildroot} ** rpmlint output is not clean: python-numexpr.src: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish python-numexpr.src: W: invalid-url Source0: http://numexpr.googlecode.com/files/numexpr-1.4.1.tar.gz HTTP Error 404: Not Found python-numexpr.x86_64: W: spelling-error %description -l en_US runtime -> run time, run-time, runtish python-numexpr.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/numexpr/interpreter.so 0775L 3 packages and 0 specfiles checked; 1 errors, 3 warnings. ** I'm not fond of using wildcards when they are not needed, as they can lead you to trouble such as owning something you're not supposed to, or not finding out if there are files missing from the release. Please be more explicit and change %{python_sitearch}/* to %{python_sitearch}/numexpr/ %{python_sitearch}/numexpr-%{version}-py*.egg-info/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
