https://bugzilla.redhat.com/show_bug.cgi?id=1944408

Robert-André Mauchin 🐧 <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebo...@gmail.com
           Assignee|nob...@fedoraproject.org    |zebo...@gmail.com
           Doc Type|---                         |If docs needed, set a value
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin 🐧 <zebo...@gmail.com> ---
Using
https://copr-be.cloud.fedoraproject.org/results/remilauzier/rudo/fedora-34-x86_64/02113875-rust-libsystemd-sys/rust-libsystemd-sys.spec

 - You need to Requires: systemd-devel so it is included in the build process
for other packages:

%package        devel
Summary:        %{summary}
BuildArch:      noarch
Requires:       systemd-devel

%description    devel %{_description}

This package contains library source intended for building other packages
which use "%{crate}" crate.

Thus you won't need to add:

echo "systemd-devel"

in dependent packages.

 - This needs to be fixed:

# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
License:        LGPLv2+ WITH [identifier] with exceptions
# FIXME: Upstream uses unknown SPDX tag WITH!

 - Don't mix tabs and spaces, remove the tabs added here:

Source1:       
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/README.md
Source2:       
https://raw.githubusercontent.com/jmesmon/rust-systemd/master/COPYING


 - Macros prefixed by two underscores are for RPM private use only, use the
actual binary instead:

cp %{SOURCE1} README.md
cp %{SOURCE2} COPYING

→

# Upstream license specification: LGPL-2.1-or-later WITH GCC-exception-2.0
# https://github.com/jmesmon/rust-systemd/issues/185
License:        LGPLv2+ with exceptions


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to