https://bugzilla.redhat.com/show_bug.cgi?id=1919639
Otto Urpelainen <otu...@iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(robert.de.rooy@gm
| |ail.com)
--- Comment #38 from Otto Urpelainen <otu...@iki.fi> ---
Thank you for the new specfile. I went through it. Findings that I missed
earlier:
- You are right about hardened build being the default. I apologize, my
mistake. Adding the line about hardening should not be required. I sent a pull
request for the Guidelines about this topic:
https://pagure.io/packaging-committee/pull-request/1064
- I think these files are actually documentation and it would be better to
install them with %doc so they would go to documentation directory instead of
data (assuming that there are not actually needed at runtime):
/usr/share/dosbox-x/CHANGELOG
/usr/share/dosbox-x/dosbox-x.reference.conf
/usr/share/dosbox-x/dosbox-x.reference.full.conf
- I see the following in build.log, perhaps you want to check if the capability
setting script actually achieved its purpose?
test -x /usr/sbin/setcap && setcap cap_net_raw=ep
/builddir/build/BUILDROOT/dosbox-x-0.83.12-2.fc35.x86_64/usr/bin/dosbox-x
unable to set CAP_SETFCAP effective capability: Operation not permitted
make: [Makefile:906: install] Error 1 (ignored)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
