https://bugzilla.redhat.com/show_bug.cgi?id=1943526



--- Comment #16 from Otto Urpelainen <otu...@iki.fi> ---
(In reply to Alessio from comment #14)
> Thank you for your patience and your advises.
> 
> These are the new files:
> Spec URL: https://alciregi.fedorapeople.org/uredir/libuev.spec
> SRPM URL:
> https://alciregi.fedorapeople.org/uredir/libuev-2.3.2-1.fc34.src.rpm

Looks good. Only two points brought up by  Robert-André Mauchin 🐧  are still
unresolved:

- Own %{_includedir}/uev/ or remove the glob. So you could do in %files simply
this and get both directory ownership and the contents installed (reference:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership):

    %{_includedir}/uev 

- explicitly BR make:

    BuildRequires: make


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to