https://bugzilla.redhat.com/show_bug.cgi?id=1945771

Brian Lane <b...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(zebo...@gmail.com
                   |                            |)



--- Comment #3 from Brian Lane <b...@redhat.com> ---
Spec URL: https://bcl.fedorapeople.org/weldr-client/weldr-client.spec
SRPM URL:
https://bcl.fedorapeople.org/weldr-client/weldr-client-35.0-2.fc32.src.rpm
Description: Command line utility to control osbuild-composer
Fedora Account System Username: bcl


weldr-client doesn't need to work on EPEL so I don't think it needs the vendor
changes so I left those out.

FWIW I'm trying to make this so that the spec is auto-generated from a template
when I run 'make srpm', you can see the template input here:
https://github.com/osbuild/weldr-client/blob/master/weldr-client.spec.in

Also, the spec should not be editing the Makefile. If there are changes needed
then they should be passed in the environment.

I may be missing the reasoning behind some of your changes, so if this still
needs work please explain in a bit more detail.

Thanks,

Brian


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to