https://bugzilla.redhat.com/show_bug.cgi?id=1947670



--- Comment #2 from Patrik Polakovič <ppola...@redhat.com> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
>  - Please use lowercase for monocypher
> 
>  - This needs to be arch specific (add isa):
> 
> Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
>  - make %{?_smp_mflags} → %make_build
> 
>  - Static libraries are generally not packaged, remove it at the end of
> install:
> 
> rm -v %{buildroot}%{_libdir}/*.a

Fixed the blockers you pointed out, and also some that one other person pointed
out on IRC. Updated my initial bug report.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to