https://bugzilla.redhat.com/show_bug.cgi?id=1906980
Ben Beasley <c...@musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #22 from Ben Beasley <c...@musicinmybrain.net> ---
Indeed. There were a lot of versions floating around. This one looks good.
I would suggest removing “-DCMAKE_CXX_FLAGS="%build_cxxflags
-DHWY_COMPILE_ALL_ATTAINABLE"”, since:
- Compiling worse-than-the-best-guaranteed-available implementations doesn’t
do anything useful except allow the upstream developers to test more
exhaustively. Specifically, it doesn’t affect the runtime requirements for the
tests, which was the goal in adding it.
- This does nothing at all on x86_64, according to my study in previous
comments.
- This might be bloating the installed library with unused implementations on
other architectures.
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
