Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=656082 --- Comment #6 from Michael Schwendt <mschwe...@gmail.com> 2010-12-23 13:31:35 EST --- Just a brief look at the spec file (no full review): > Source0: http://downloads.sourceforge.net/cprops/libcprops-0.1.8.tar.bz2 Nowadays when there are tools to parse a spec file in order to retrieve a download URL, it isn't beneficial anymore to hardcode the version number. It's more convenient and less error-prone to use %{version} instead. Occasionally, a packager updates just the "Version:" tag to 0.1.9 and that works accidentally if the old tarball is still available. > %if %with postgres > BuildRequires: postgresql-devel > Requires: postgresql > %endif https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires > %files devel > %defattr(-,root,root,-) > %doc %{_mandir}/man3/* Files below %_mandir are %doc by default. > %dir %{_includedir}/cprops/ > %{_includedir}/cprops/* Since the '*' wildcard catches all files, you could replace the two lines with just %{_includedir}/cprops/ which includes the directory and its contents. The trailing slash is optional and just for increased readability. To make it more explicit that the entry is a directory tree and not a single file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
