https://bugzilla.redhat.com/show_bug.cgi?id=1958895
Karolina Surma <ksu...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #8 from Karolina Surma <ksu...@redhat.com> ---
Thanks!
Just two nitpicks:
"rm -rf %{undername}.egg-info" in %prep is not necessary, the source tarball
doesn't have any egg-info's.
There are two writing conventions mixed in BuildRequires, I'd go for better
readability and unify them. But technically it doesn't make a difference
BuildRequires: %{py3_dist pytest}
BuildRequires: python3-pytest-asyncio
Those are not blockers, the package is APPROVED.
Full Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* Apache License 2.0". 77
files have unknown license. Detailed output of licensecheck in
/home/ksurma/tmp/1958895-python-socks/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-socks-1.2.4-1.fc35.noarch.rpm
python3-socks+asyncio-1.2.4-1.fc35.noarch.rpm
python3-socks+curio-1.2.4-1.fc35.noarch.rpm
python3-socks+trio-1.2.4-1.fc35.noarch.rpm
python-socks-1.2.4-1.fc35.src.rpm
python3-socks.noarch: W: spelling-error %description -l en_US async -> sync, a
sync
python3-socks.noarch: W: spelling-error %description -l en_US aiohttp
python3-socks.noarch: W: spelling-error %description -l en_US httpx -> HTTP
python3-socks+asyncio.noarch: W: spelling-error Summary(en_US) Metapackage ->
Meta package, Meta-package, Prepackage
python3-socks+asyncio.noarch: W: spelling-error Summary(en_US) asyncio ->
syncopation
python3-socks+asyncio.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
python3-socks+asyncio.noarch: W: spelling-error %description -l en_US asyncio
-> syncopation
python3-socks+asyncio.noarch: W: no-documentation
python3-socks+curio.noarch: W: spelling-error Summary(en_US) Metapackage ->
Meta package, Meta-package, Prepackage
python3-socks+curio.noarch: W: spelling-error %description -l en_US metapackage
-> meta package, meta-package, prepackage
python3-socks+curio.noarch: W: no-documentation
python3-socks+trio.noarch: W: spelling-error Summary(en_US) Metapackage -> Meta
package, Meta-package, Prepackage
python3-socks+trio.noarch: W: spelling-error %description -l en_US metapackage
-> meta package, meta-package, prepackage
python3-socks+trio.noarch: W: no-documentation
python-socks.src: W: spelling-error %description -l en_US async -> sync, a sync
python-socks.src: W: spelling-error %description -l en_US asyncio ->
syncopation
python-socks.src: W: spelling-error %description -l en_US aiohttp
python-socks.src: W: spelling-error %description -l en_US httpx -> HTTP
5 packages and 0 specfiles checked; 0 errors, 18 warnings.
Rpmlint (installed packages)
----------------------------
python3-socks+asyncio.noarch: W: spelling-error Summary(en_US) Metapackage ->
Meta package, Meta-package, Prepackage
python3-socks+asyncio.noarch: W: spelling-error Summary(en_US) asyncio ->
syncopation
python3-socks+asyncio.noarch: W: spelling-error %description -l en_US
metapackage -> meta package, meta-package, prepackage
python3-socks+asyncio.noarch: W: spelling-error %description -l en_US asyncio
-> syncopation
python3-socks+asyncio.noarch: W: no-documentation
python3-socks+trio.noarch: W: spelling-error Summary(en_US) Metapackage -> Meta
package, Meta-package, Prepackage
python3-socks+trio.noarch: W: spelling-error %description -l en_US metapackage
-> meta package, meta-package, prepackage
python3-socks+trio.noarch: W: no-documentation
python3-socks+curio.noarch: W: spelling-error Summary(en_US) Metapackage ->
Meta package, Meta-package, Prepackage
python3-socks+curio.noarch: W: spelling-error %description -l en_US metapackage
-> meta package, meta-package, prepackage
python3-socks+curio.noarch: W: no-documentation
python3-socks.noarch: W: spelling-error %description -l en_US async -> sync, a
sync
python3-socks.noarch: W: spelling-error %description -l en_US aiohttp
python3-socks.noarch: W: spelling-error %description -l en_US httpx -> HTTP
4 packages and 0 specfiles checked; 0 errors, 14 warnings.
Source checksums
----------------
https://github.com/romis2012/python-socks/archive/v1.2.4/python-socks-1.2.4.tar.gz
:
CHECKSUM(SHA256) this package :
a7a996f90238c91be047839d887ea6ef4cb0c3c33120bf07a62d5ea56aca27d3
CHECKSUM(SHA256) upstream package :
a7a996f90238c91be047839d887ea6ef4cb0c3c33120bf07a62d5ea56aca27d3
Requires
--------
python3-socks (rpmlib, GLIBC filtered):
python(abi)
python3-socks+asyncio (rpmlib, GLIBC filtered):
python(abi)
python3-socks
python3.9dist(async-timeout)
python3-socks+curio (rpmlib, GLIBC filtered):
python(abi)
python3-socks
python3.9dist(curio)
python3-socks+trio (rpmlib, GLIBC filtered):
python(abi)
python3-socks
python3.9dist(trio)
Provides
--------
python3-socks:
python-socks
python3-socks
python3.9-socks
python3.9dist(python-socks)
python3dist(python-socks)
python3-socks+asyncio:
python-socks+asyncio
python3-socks+asyncio
python3.9-socks+asyncio
python3.9dist(python-socks[asyncio])
python3dist(python-socks[asyncio])
python3-socks+curio:
python-socks+curio
python3-socks+curio
python3.9-socks+curio
python3.9dist(python-socks[curio])
python3dist(python-socks[curio])
python3-socks+trio:
python-socks+trio
python3-socks+trio
python3.9-socks+trio
python3.9dist(python-socks[trio])
python3dist(python-socks[trio])
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
