Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663244 --- Comment #3 from Michael Schwendt <mschwe...@gmail.com> 2010-12-25 03:48:20 EST --- > Please use > --datarootdir=%{_datadir} > instead of > --datarootdir=/usr/share/ > and %{_datadir} in place of %{_datarootdir} in %files, just to stick to > convention. Why set --datarootdir at all? Its default is ${prefix}/share (also see rpm --eval %_datarootdir). ${datadir} is set to ${datarootdir}, and lots of other autoconf variables are derived from that value. And %configure already sets --datadir=/usr/share, too. Then, where you use a fragile sed pattern to replace "prefix" with "datarootdir", you could use the default datadir instead. Or even better, replace the sed substitution (which may fail silently or cause damage) with a clean patch that would fail to apply if the patch target has changed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
