Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=665995 Kevin Kofler <ke...@tigcc.ticalc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ke...@tigcc.ticalc.org --- Comment #9 from Kevin Kofler <ke...@tigcc.ticalc.org> 2010-12-29 17:40:35 EST --- If a library should always be built as static, which is the case for those convenience libraries, you MUST use the STATIC keyword in add_library. The default is determined by the distribution. We default to shared libraries because we generally want libraries to be shared when both options exist (which should really be the case for all libraries). For those libraries which do make sense to be shared, they should be properly versioned with set_target_properties (the VERSION and SOVERSION properties must be set properly), and you should not specify STATIC or SHARED explicitly, this is supposed to be decided by whoever builds the software. IMHO the fact that CMake defaults to static is broken: When both options exist, the default should be shared, at least on GNU/Linux. (In the absence of dependency resolution, static libraries can be useful. In its presence, not really.) But this is exactly why we set BUILD_SHARED_LIBS. But this is for true libraries, which are installed as such. In this case, the libraries are only convenience libraries and not actually installed, so it doesn't make sense to build them shared. Therefore, the add_library call must use STATIC explicitly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review