https://bugzilla.redhat.com/show_bug.cgi?id=1974377
Fabio Valentini <decatho...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Fabio Valentini <decatho...@gmail.com> ---
Minor issues:
0) remove markdown markup from Summary
Please remove markdown markup characters (`) from the Summary tag.
1) "# check has missing dependencies"
Please list which dependencies are missing.
2) %description
Looks like you changed "Clang's" to "Clang" in the generated description. Why?
3) %license in %files
To be consistent with ~all~ other Rust packages (and to make version rebases
easier for me), change to this please:
%files devel
%license LICENSE-APACHE LICENSE-MIT
%doc README.md
4) changelog date format
Please remove the time and timezone from the date in the changelog entry.
This broken format is only used by rust2rpm any longer and I hope to be able to
remove it there with the next version as well.
---
All those are very minor or cosmetic issues. Other than those:
Package was generated with rust2rpm, simplifying the review process.
- package conforms to Rust packaging Guidelines ✅
- Latest version is packaged ✅
- License correct, acceptable, and LICENSE files shipped with %license ✅
- package builds and installs without errors in mock / rawhide ✅
Package APPROVED.
Please make the small adaptations listed above before importing the package to
Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
