Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=665395 Thomas Woerner <twoer...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(nob...@fedoraproj | |ect.org) --- Comment #2 from Thomas Woerner <twoer...@redhat.com> 2011-01-03 10:40:17 EST --- Hi Karsten, thanks for the review. Here is the fixed package.. FIXED: Source tag, tarball not available at the given URL FIXED: Requires(post) and (pre) for chkconfig FIXED: license FIXED: source uploaded to https://fedorahosted.org/released/ FIXED: non-executable-scripts FIXED: non-conffile-in-etc /etc/dbus-1/system.d/FirewallD.conf FIXED: mixed-use-of-spaces-and-tabs NOTABUG: incoherent-subsys If I am replacing $prog in lockfile=/var/lock/subsys/$prog with firewalld, then the error is gone. $prog contains firewalld, therefore this is not a bug. NOTABUG: The spelling warning seems to be a dictionary problem. NOTABUG: firewall-applet does not have a separate documentation and it is requiring the base package that contains %doc Please have a look at: http://twoerner.fedorapeople.org/firewalld/firewalld.spec http://twoerner.fedorapeople.org/firewalld/firewalld-0.1.2-1.fc14.src.rpm Thanks, Thomas -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
