https://bugzilla.redhat.com/show_bug.cgi?id=1978515



--- Comment #19 from Hangbin Liu <ha...@redhat.com> ---
(In reply to Mikel Olasagasti Uranga from comment #16)
> Hi Hangbin,
> 
> - Two obsoleted m4 macros are used, you may want to report that upstream.

Thanks, I will see how to fix it and post to upstream

> - As Makefile.am is LGPLv2, you should add that license also in the spec or
> ask upstream to change to GPLv2 to match the rest of the code. Fix this
> before pushing the new spec to git.

I'd prefer to update the license to spec file first and open an issue upstream
to see if Neil would like to update the license.

Here are the updated spec file(update license to LGPLv2, fixes the manpage to
1*) and SRPM:

SPEC URL: https://people.redhat.com/haliu/dropwatch/dropwatch.spec

SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/323/71390323/dropwatch-1.5.3-5.fc34.src.rpm

Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=71390322


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to