Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=666954

--- Comment #8 from Thomas Spura <toms...@fedoraproject.org> 2011-01-04 
17:03:15 EST ---
(In reply to comment #1)
> Thomas, this is python. ;)

Hehe, nice ;-)

(In reply to comment #7)
> * I hope you can convince upstream to rid of gtk requirement from setup.py. It
> should be an easy job.

Not that easy...
gtk is not required in setup.py. They import the cons module to get the version
from there. So it would be best, if they would introduce a new *.py file for
the gtk variables and import it from there.
(patch below)

But I would suggest to not install into %{python_sitelib}, because upstream
(and so othere distributions don't do that too, but your choice ;-)

It's starting up, but it would be better to ask upstream, if the patch is ok...

SPEC: http://tomspur.fedorapeople.org/review/cherrytree.spec
PATCH:http://tomspur.fedorapeople.org/review/cherrytree-gtk-dep.patch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to