https://bugzilla.redhat.com/show_bug.cgi?id=1982618
--- Comment #2 from Tomas Korbar <tkor...@redhat.com> ---
Hi Christopher,
i have a few comments, regarding this package.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 10 files have unknown license. Detailed
output of licensecheck in /home/tkorbar/packaging/fedora/reviews/php-
christophwurst-id3parser/php-christophwurst-id3parser/licensecheck.txt
----- I do not think that license should be GPLv3+ but GPLv3 instead.
[ ]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/php/ID3Parser(php-
lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3(php-
lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3/Tags(php-
lukasreschke-id3parser)
----- unfortunatelly this conflict will need to be resolved.
You can use the solution Remi suggested.
[ ]: Package does not generate any conflict.
----- Same as before, there is a conflict with lukasreschkes project
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
