https://bugzilla.redhat.com/show_bug.cgi?id=1984419
--- Comment #7 from LumÃr Balhar <lbal...@redhat.com> --- > I guess this is not primarily an application despite having one, right? > Would users try to dnf install normalizer? Your guess is correct. Because this package is a replacement for chardet, which also contains kinda hidden application, I've decided to package it in the same way. > 1) Fix end of lines of README. Done in spec and reported upstream: https://github.com/Ousret/charset_normalizer/issues/66 > The package currently has no runtime requires. But it might have some in the > future. And since you run tests in %check, I recommend using > %pyproject_buildrequires with -r (for runtime). That way, missing runtime > requirements won't fail the tests in weird ways in the future and you'll > also have a better build failure in case the new dependency is not available > in Fedora yet. Fixed. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
