https://bugzilla.redhat.com/show_bug.cgi?id=1975845

Petr Menšík <pemen...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #8 from Petr Menšík <pemen...@redhat.com> ---
It seems to me devel subpackage should also own gir-1.0 directory, but review
package does not compliain about it. I guess it is covered indirectly via gtk4.
It would not hurt explicitly owning parent directory. Since vala is required by
devel, only files from this package need to be owned, not the directory itself.

%files devel
%dir %{_datadir}/gir-1.0
%{_datadir}/gir-1.0/*-%{apiver}.gir
%{_datadir}/vala/vapi/%{name}-%{apiver}.*

But those are just cosmetic changes. I think the package is ready, thank you
for your contribution!


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to