https://bugzilla.redhat.com/show_bug.cgi?id=1982011
--- Comment #6 from Petr Menšík <pemen...@redhat.com> ---
Wait.
Your package uses %systemd_post etc., but does not use %{?systemd_requires} to
require systemd during upgrades. It seems that case is well covered and it
makes sense to work even without systemd. Not necessary it seems, but would
solve unowned %_unitdir.
Another recommendation would be using unprivileged user for netperf service. It
uses root user, which is dangerous. I haven't found whether it is mandatory, I
think it should be therefore just recommended. Consult user and groups [1] in
Guidelines. I think at minimum DynamicUser=yes feature of systemd should be
used to run non-privileged service. I just guess it does not require special
privileges, capabilities(7) would provide ability to grant just few required
permissions in the other case.
1. https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
