https://bugzilla.redhat.com/show_bug.cgi?id=1982619
Otto Urpelainen <otu...@iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(otu...@iki.fi) |
--- Comment #6 from Otto Urpelainen <otu...@iki.fi> ---
Thank you for packaging this, everything looks good, so review passed.
It is good if you can discuss the naming scheme with upstream.
For now, the current naming scheme is ok as discussed above.
Fedora actually has phpunit available from major version 6 onwards,
so even staying with 7 would have been acceptable,
it is not a huge deal to use an end-of-life test runner.
Of course it is much better that you patched the tests
so a newer version can be used.
If you get in touch with upstream about phpunit 9 support,
you could take care of this warning that is currently emitted:
> Warning - The configuration file did not pass validation!
> The following problems have been detected:
>
> Line 12:
> - Element 'phpunit', attribute 'syntaxCheck': The attribute 'syntaxCheck' is
> not allowed.
>
> Test results may not be as expected.
Apparently, the warning is harmless in itself,
but that attribute could and should just be removed [1].
[1]: https://stackoverflow.com/a/44331140
I will take one more of your php requests when I find the time,
assuming there are still some left.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
