https://bugzilla.redhat.com/show_bug.cgi?id=1979081



--- Comment #5 from Georg Sauthoff <fed...@georg.so> ---
> Those are BuildRequires taken from gemspec, the maintainer should then decide 
> what makes sense to be included and what does not ;)

Sure, but if a requirement is indeed superfluous on fedora, then gem2rpm could
filter it, i.e. when using a fedora template.

However,

> This minimal patch should work
> ~~~
> -%if 0%{?fedora} < 34
> -BuildRequires: rubygem(ronn)
> -%else
> -BuildRequires: rubygem(ronn-ng)
> -%endif
> +BuildRequires: %{_bindir}/ronn
> ~~~

No, it doesn't work. With that change the build fails on Copr:

+ rspec spec
/var/tmp/rpm-tmp.UCjJBV: line 33: rspec: command not found

https://copr.fedorainfracloud.org/coprs/gsauthof/fedora/build/2454151/


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to