https://bugzilla.redhat.com/show_bug.cgi?id=1991092
--- Comment #3 from Sahana Prasad <sah...@redhat.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE.md is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* [generated file]", "Expat License [generated file]", "*No copyright* Expat License", "ISC License", "Expat License ISC License", "*No copyright* Apache License 2.0", "Apache License 2.0". 6716 files have unknown license. Detailed output of licensecheck in /home/dbelyavs/tmp/1991092-nodejs-diagnostic-language- server/licensecheck.txt [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/node_modules(nodejs, nodejs-bash-language-server) [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define pkg_name diagnostic- languageserver [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nodejs-diagnostic-language-server-1.12.0-1.fc35.noarch.rpm nodejs-diagnostic-language-server-1.12.0-1.fc35.src.rpm nodejs-diagnostic-language-server.noarch: W: spelling-error Summary(en_US) linters -> liners, liters, inters nodejs-diagnostic-language-server.noarch: W: spelling-error %description -l en_US linters -> liners, liters, inters nodejs-diagnostic-language-server.noarch: W: spelling-error %description -l en_US yamllint -> lineament nodejs-diagnostic-language-server.noarch: W: spelling-error %description -l en_US languagetool -> language tool, language-tool, metalanguage nodejs-diagnostic-language-server.noarch: E: useless-provides bundled(nodejs-tslib) nodejs-diagnostic-language-server.noarch: W: only-non-binary-in-usr-lib nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/.bin nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/.bin nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/out/types/index.js nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/out/types/index.js nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/out/types/index.js nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/array-union/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/aggregate-error/license nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/clean-stack/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/aggregate-error/license nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/clean-stack/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/array-union/license nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/crypto-random-string/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/aggregate-error/license nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/crypto-random-string/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/array-union/license nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/crypto-random-string/license /usr/lib/node_modules/diagnostic-languageserver/node_modules/clean-stack/license nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/del/node_modules/.bin nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/del/node_modules/.bin nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.scandir/out/types/index.js nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.stat/out/types/index.js nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/fast-glob/out/types/index.js /usr/lib/node_modules/diagnostic-languageserver/node_modules/@nodelib/fs.walk/out/types/index.js nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/fastq/.github nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/fastq/.github nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-jsonrpc/License.txt nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver-protocol/License.txt nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver/License.txt /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver-types/License.txt nodejs-diagnostic-language-server.noarch: E: wrong-script-end-of-line-encoding /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver/bin/installServerIntoExtension nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-languageserver/typings/thenable.d.ts /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-jsonrpc/typings/thenable.d.ts nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-uri/.vscode nodejs-diagnostic-language-server.noarch: W: hidden-file-or-dir /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-uri/.vscode nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-uri/lib/umd/index.d.ts /usr/lib/node_modules/diagnostic-languageserver/node_modules/vscode-uri/lib/esm/index.d.ts nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/wrappy/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/minimatch/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/wrappy/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/once/LICENSE nodejs-diagnostic-language-server.noarch: W: cross-directory-hard-link /usr/lib/node_modules/diagnostic-languageserver/node_modules/wrappy/LICENSE /usr/lib/node_modules/diagnostic-languageserver/node_modules/rimraf/LICENSE nodejs-diagnostic-language-server.noarch: W: no-manual-page-for-binary diagnostic-languageserver nodejs-diagnostic-language-server.src: W: spelling-error Summary(en_US) linters -> liners, liters, inters nodejs-diagnostic-language-server.src: W: spelling-error %description -l en_US linters -> liners, liters, inters nodejs-diagnostic-language-server.src: W: spelling-error %description -l en_US yamllint -> lineament nodejs-diagnostic-language-server.src: W: spelling-error %description -l en_US languagetool -> language tool, language-tool, metalanguage nodejs-diagnostic-language-server.src: W: invalid-url Source1: diagnostic-languageserver-1.12.0-vendor.tar.xz 2 packages and 0 specfiles checked; 3 errors, 727 warnings. going through the errors, the first 2 are not applicable. The last one is not critical. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/iamcco/diagnostic-languageserver/archive/v1.12.0/diagnostic-languageserver-1.12.0.tar.gz : CHECKSUM(SHA256) this package : 67f6904e3a6dcc6463aac57fc223175b21d7f13239a17256f0834e50485cb7a0 CHECKSUM(SHA256) upstream package : 67f6904e3a6dcc6463aac57fc223175b21d7f13239a17256f0834e50485cb7a0 Requires -------- nodejs-diagnostic-language-server (rpmlib, GLIBC filtered): /usr/bin/node Provides -------- nodejs-diagnostic-language-server: bundled(nodejs-aggregate-error) bundled(nodejs-array-union) bundled(nodejs-balanced-match) bundled(nodejs-brace-expansion) bundled(nodejs-braces) bundled(nodejs-clean-stack) bundled(nodejs-commander) bundled(nodejs-concat-map) bundled(nodejs-crypto-random-string) bundled(nodejs-del) bundled(nodejs-dir-glob) bundled(nodejs-fast-glob) bundled(nodejs-fastq) bundled(nodejs-fill-range) bundled(nodejs-find-up) bundled(nodejs-fs.realpath) bundled(nodejs-glob) bundled(nodejs-glob-parent) bundled(nodejs-globby) bundled(nodejs-graceful-fs) bundled(nodejs-ignore) bundled(nodejs-indent-string) bundled(nodejs-inflight) bundled(nodejs-inherits) bundled(nodejs-is-extglob) bundled(nodejs-is-glob) bundled(nodejs-is-number) bundled(nodejs-is-path-cwd) bundled(nodejs-is-path-inside) bundled(nodejs-is-stream) bundled(nodejs-locate-path) bundled(nodejs-lodash) bundled(nodejs-merge2) bundled(nodejs-micromatch) bundled(nodejs-minimatch) bundled(nodejs-once) bundled(nodejs-p-limit) bundled(nodejs-p-locate) bundled(nodejs-p-map) bundled(nodejs-p-try) bundled(nodejs-path-exists) bundled(nodejs-path-is-absolute) bundled(nodejs-path-type) bundled(nodejs-picomatch) bundled(nodejs-reusify) bundled(nodejs-rimraf) bundled(nodejs-run-parallel) bundled(nodejs-rxjs) bundled(nodejs-slash) bundled(nodejs-temp-dir) bundled(nodejs-tempy) bundled(nodejs-to-regex-range) bundled(nodejs-tslib) bundled(nodejs-type-fest) bundled(nodejs-unique-string) bundled(nodejs-vscode-jsonrpc) bundled(nodejs-vscode-languageserver) bundled(nodejs-vscode-languageserver-protocol) bundled(nodejs-vscode-languageserver-textdocument) bundled(nodejs-vscode-languageserver-types) bundled(nodejs-vscode-uri) bundled(nodejs-wrappy) nodejs-diagnostic-language-server npm(diagnostic-languageserver) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1991092 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Perl, Ocaml, R, Java, fonts, PHP, C/C++, Python, Haskell, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
