https://bugzilla.redhat.com/show_bug.cgi?id=1970050
Neal Gompa <ngomp...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(zebo...@gmail.com |
|) |
Status|ASSIGNED |POST
--- Comment #30 from Neal Gompa <ngomp...@gmail.com> ---
Review notes:
* Package complies with Fedora Packaging Guidelines
* Package complies (mostly) with Go packaging guidelines
* Package builds and installs
* Package has correct licensing and license files are installed
* No serious issues from rpmlint
There are a couple of minor things you should fix on import:
* cri-o.src: E: summary-too-long C Open Container Initiative-based
implementation of Kubernetes Container Runtime Interface
* cri-o.src: E: specfile-error warning: bogus date in %changelog: Thu May 16
2020 Douglas Schilling Landgraf <dougsl...@redhat.com> - 2:1.18.1-1
There's an odd error that I *think* looks like an upstream software bug?
* cri-o.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/pinns
Regardless, I think we're in good shape here, so...
PACKAGE APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
