https://bugzilla.redhat.com/show_bug.cgi?id=1981982
--- Comment #5 from Didik Supriadi <[email protected]> --- > Issues: > ======= > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros You should not mix %{buildroot} and $RPM_BUILD_ROOT See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags > - Javadoc documentation files are generated and included in -javadoc > subpackage > Note: No javadoc subpackage present. Note: Javadocs are optional for > Fedora versions >= 21 > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation > - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) > Note: No javadoc subpackage present > See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation There is no javadoc generation. > ===== MUST items ===== > > Generic: > [ ]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. > Note: Using prebuilt packages There is: * org apache commons lang in core/src/ folder * org gudy bouncycastle * in core/src/ folder * org json simple in core/src/folder * org eclipse swt widgets in uis/src/ folder is that packages bundled in biglybt? they should be unbundled if possible See https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/application- > registry Using unowned directory: /usr/share/application-registry See https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ > Rpmlint > ------- > Checking: biglybt-2.8.0.0-1.fc36.noarch.rpm > biglybt-2.8.0.0-1.fc36.src.rpm > biglybt.noarch: W: spelling-error Summary(en_US) bittorrent -> bit torrent, > bit-torrent, BitTorrent > biglybt.src: W: spelling-error Summary(en_US) bittorrent -> bit torrent, > bit-torrent, BitTorrent > biglybt.noarch: W: summary-ended-with-dot C Source for BiglyBT, a feature > filled, open source, ad-free, bittorrent client. > biglybt.src: W: summary-ended-with-dot C Source for BiglyBT, a feature > filled, open source, ad-free, bittorrent client. Simply remove the trailing period from the summary field. > biglybt.noarch: W: name-repeated-in-summary C BiglyBT > biglybt.src: W: name-repeated-in-summary C BiglyBT > biglybt.noarch: E: description-line-too-long C BiglyBT is forked from > Vuze/Azureus and is being maintained by two of the original developers as > well as members of the community. > biglybt.src: E: description-line-too-long C BiglyBT is forked from > Vuze/Azureus and is being maintained by two of the original developers as > well as members of the community. You should split your description, where each line does not exceed 80 characters. > biglybt.noarch: W: class-path-in-manifest /usr/share/java/biglybt/BiglyBT.jar JAR files must not include class-path entry inside META-INF/MANIFEST.MF (See https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#_no_class_path_in_manifest_mf) You could remove it by using `sed -i '/class-path/I d' META-INF/MANIFEST.MF`, for example. > biglybt.src: W: strange-permission biglybt.desktop 775 A file that you listed in *.src.rpm has strange permissions. Use chmod to change it. > biglybt.src:105: W: macro-in-comment %{buildroot} > biglybt.src:105: W: macro-in-comment %{_bindir} Removes these comments > 2 packages and 0 specfiles checked; 2 errors, 10 warnings. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
