https://bugzilla.redhat.com/show_bug.cgi?id=1997378
Miroslav Suchý <msu...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |msu...@redhat.com
--- Comment #16 from Miroslav Suchý <msu...@redhat.com> ---
One nitpick:
> %if 0%{?fedora} < 35
This can cause problems when downstreaming. E.g. This becomes true on RH 9 (or
10). Because the macro fedora is not defined there and it becomes 0 < 35 which
is True.
It is better to write it as:
> %if 0%{?fedora} && 0%{?fedora} < 35
or you can reverse the condition
%if 0%{?fedora} < 35
#nothing to do here because.....
%elif
Requires:.....
%endif
But this definitely does not block the review.
I explained to Marek the processes in Fedora and how to do the things.
I granted Marek the packager role.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1997378
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
