Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=652616 --- Comment #3 from Peter Lemenkov <lemen...@gmail.com> 2011-01-11 07:07:05 EST --- (In reply to comment #2) > I take this one. If you like, I'd appreciate a review of the tiny xqc package > (bug #655866) :) > > Some initial comments: > > - The binary package provides the erlang extension library ebloom_nifs.so. > Is this library supposed to be accessible by other external applications > too? > If not, I suggest to filter it from the provides list as described in > http://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering Yes, indeed - this should be filtered out. http://peter.fedorapeople.org/erlang-ebloom.spec http://peter.fedorapeople.org/erlang-ebloom-1.0.2-2.fc12.src.rpm I added only filtering of internal dynamic library - no other changes. > - you can simplify the %files section by replacing all file/dir lines with the > single line > %{_libdir}/erlang/lib/%{realname}-%{version}/ > But that's optional and a matter of personal preference Actually, I personally prefer to list them in this way :). I plan to write a checking tool which would analyze %files sections for my internal needs, so I would need full enumeration of packaged files and directories. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
