https://bugzilla.redhat.com/show_bug.cgi?id=2053964

Mikel Olasagasti Uranga <mi...@olasagasti.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |mi...@olasagasti.info
           Assignee|nob...@fedoraproject.org    |mi...@olasagasti.info



--- Comment #1 from Mikel Olasagasti Uranga <mi...@olasagasti.info> ---
> %global common_description %{expand:
> :sparkles: QR Code encoder (Go).}
> (...)
> Summary:        :sparkles: QR Code encoder (Go)

Remove the `:sparkles:` emoji. 

> # Generated by go2rpm 1.6.0
> %bcond_with check

The tests can be fixed by applying the patch in
https://github.com/skip2/go-qrcode/pull/53

You can use

%bcond_without check
(...)
Source0:        %{gosource}
Patch0001:     
https://patch-diff.githubusercontent.com/raw/skip2/go-qrcode/pull/53.patch
(...)
%goprep
%patch0001 -p1

> %generate_buildrequires
> %go_generate_buildrequires

Currently doesn't have any dep, you can remove this.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2053964
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to