Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=668090 Mohammed Morsi <mmo...@redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mmo...@redhat.com AssignedTo|nob...@fedoraproject.org |mmo...@redhat.com Flag| |fedora-review? --- Comment #1 from Mohammed Morsi <mmo...@redhat.com> 2011-01-18 23:56:52 EST --- Will take this one. This rpm is dependent on rubygem-activesupport (3.0.3), rubygem-actionpack (3.0.3), and thor (0.14.6) making it into Fedora first. * rpmlint spits out some errors which can't be ignored rubygem-railties-doc.noarch: E: script-without-shebang /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/guides/assets/stylesheets/syntaxhighlighter/shThemeMDUltra.css This stylesheet seems to be mistakingly marked as executable in the upstream source, can prolly chmod it to remove the executable permission rubygem-railties.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory rubygem-railties.noarch: E: zero-length /usr/lib/ruby/gems/1.8/gems/railties-3.0.3/lib/rails/generators/rails/app/templates/test/fixtures/.empty_directory There are a bunch of these errors for various .empty_directory files in the railties gem, these need to be included in the project correct? The other rpmlint warnings can be ignored * rm -rf %{buildroot} at the beginning of %install isn't needed and should be removed * Feel free to tar up the upstream test suite for the 3.0.3 railties release and run it in a %check section in the rpm Other than that looks good and complies to guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
