https://bugzilla.redhat.com/show_bug.cgi?id=2072599
Mikel Olasagasti Uranga <mi...@olasagasti.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mi...@olasagasti.info
Doc Type|--- |If docs needed, set a value
Assignee|nob...@fedoraproject.org |mi...@olasagasti.info
--- Comment #1 from Mikel Olasagasti Uranga <mi...@olasagasti.info> ---
> %global codate 20220206
> Release: %autorelease -s %{codate}git%{shortcommit}
Although this is correct, you used another formula in the googleapi's spec.
Check which format you want to use for more homogeneity in your specs.
> %global debug_package %{nil}
Why disable the debug package?
> buildRequires: libpng-devel
> buildRequires: libjpeg-turbo-devel
Capitalize to BuildRequires. Ordering BR alphabetically can be useful also.
> g++ pdfsign.cpp -I/usr/include/podofo/ -lpodofo -ljpeg -lfreetype -lpng -lz
> -lcrypto -lpthread -lfontconfig %{optflags} %{build_ldflags} -o pdfsign
You can add %{optflags} %{build_ldflags} to that command to use Fedora's
defined hardening flags.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2072599
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
