https://bugzilla.redhat.com/show_bug.cgi?id=2097925
--- Comment #1 from Andreas Schneider <a...@redhat.com> ---
I think
BuildRequires: python%{python3_pkgversion}-setuptools
...
should be:
BuildRequires: python3dist(setuptools)
...
======================================================
I would prefer if you use:
install -d -m 0755 directory
instead of -p in the install command
also mkdir -p should be install -d -m 0755 ..
======================================================
# Install configuration files.
install -d %{buildroot}%{_sysconfdir}/%{name}
install -p -m 644 conf/cepces.conf.dist \
%{buildroot}%{_sysconfdir}/%{name}/cepces.conf
install -p -m 644 conf/logging.conf.dist \
%{buildroot}%{_sysconfdir}/%{name}/logging.conf
install -d %{buildroot}%{_libexecdir}/certmonger
install -p -m 755 bin/%{name}-submit \
%{buildroot}%{_libexecdir}/certmonger/%{name}-submit
# Remove unused executables and configuration files.
%{__rm} -rfv %{buildroot}/usr/local/etc
%{__rm} -rfv %{buildroot}/usr/local/libexec/certmonger
I would prefer if you fix setup.py instead installing and removing those
scripts and configs.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2097925
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
