https://bugzilla.redhat.com/show_bug.cgi?id=2099789
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Doc Type|--- |If docs needed, set a value
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
"%pytest" → "%pytest -v"
rpmautospec?
Maybe add "Recommends:kmod" for /sbin/modprobe.
"Requires: python3-pepc" → "Requires: python3-pepc = %{version}-%{relese}"
(For your own sanity: you want to avoid the situation where there's some
dependency
issue and users and up with mismatched versions of the subpackages.)
+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly (SPDX)
+ latest version: 1.3.9 was released a few days ago, but it seems that it just
added a spec file for Fedora.
So that's fine too.
+ BR/R look fine
+ builds and installs OK, seems to work OK
rpmlint:
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepclibs/helperlibs/EmulProcessManager.py 644
/usr/bin/env python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_Pepc.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_PepcASPM.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_PepcCPUHotplug.py 644
/usr/bin/python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_PepcCStates.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_PepcCommon.py 644 /usr/bin/python3
python3-pepc.noarch: E: non-executable-script
/usr/lib/python3.11/site-packages/pepctool/_PepcPStates.py 644 /usr/bin/python3
→ Meh :]
python3-pepc.noarch: W: no-documentation
pepc.noarch: W: invalid-license BSD-3-Clause
pepc.src: W: invalid-license BSD-3-Clause
python3-pepc.noarch: W: invalid-license BSD-3-Clause
→ rpmlint doesn't grok SPDX.
Package is APPROVED.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2099789
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
