https://bugzilla.redhat.com/show_bug.cgi?id=2097476

Ben Beasley <c...@musicinmybrain.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |c...@musicinmybrain.net



--- Comment #2 from Ben Beasley <c...@musicinmybrain.net> ---
I was starting to review this, and I wrote this:

- The PyPI source archive lacks the license text because that is at the top    
                                        level of the git repository, but the
Apache license requires the text to be
  distributed.

  Consider filing an upstream issue about the missing license file. You could
  add the license files as additional sources:

    Source1:
https://github.com/apache/arrow/raw/apache-arrow-%{version}/LICENSE.txt
    Source2:
https://github.com/apache/arrow/raw/apache-arrow-%{version}/NOTICE.txt

  Or, you could use the full GitHub archive as the source,

    Source0:
https://github.com/apache/arrow/archive/apache-arrow-%{version}/arrow-apache-arrow-%{version}.tar.gz

  and then do something like this in %prep:

    # Remove non-Python sources:
    find . -mindepth 1 -maxdepth 1 -type d ! -name python -print -exec rm -rf

…but then I considered that I had just recommended using the same source
archive as libarrow[1]. Perhaps it would be better to add python3-pyarrow as an
additional subpackage in libarrow instead, rather than managing it as a
separate package.

[1] https://src.fedoraproject.org/rpms/libarrow


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2097476
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to