https://bugzilla.redhat.com/show_bug.cgi?id=2116087
--- Comment #2 from Orion Poplawski <or...@nwra.com> --- (In reply to Fabio Valentini from comment #1) > > Source1: http://www.apache.org/licenses/LICENSE-2.0 > > Source2: http://opensource.org/licenses/MIT > > These are both wrong - they point at HTML pages, not at raw text files. > Additionally, the link for MIT doesn't resolve, because that site is now > HTTPS only. > > You should instead file a PR with the upstream project to add the license > files (not HTML dumps :), and then you can link the files from your PR. > You can look at how must Rust crates (for example, > https://github.com/seanmonstar/reqwest) handle this for "inspiration". > For example, the "LICENSE-APACHE" and "LICENSE-MIT" file names are pretty > standardized across the whole ecosystem. Done. > > # Update version deps > > # https://github.com/ejmahler/strength_reduce/pull/6 > > Patch: rust-strength_reduce-deps.patch > > You might be interested in rust2rpm's "-p" flag, which automates generation > of patches like this one. Good to know, thanks. > Please also include a link to the PR that you filed upstream for this. Already there. > It also looks like you uploaded an SRPM file that was already mangled by > rpmautospec: > > > %changelog > > * Sat Aug 06 2022 John Doe <packa...@example.com> 0.2.3-1 > > - Uncommitted changes Mainly just not having set %packager I think. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2116087 _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
