Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=671079 --- Comment #2 from Vitezslav Crhonek <vcrho...@redhat.com> 2011-01-24 08:20:07 EST --- (In reply to comment #1) > First iteration of review: > please, use %global instead of %define macros - see > https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Fixed. > > you could drop BuildRoot, it is no longer necessary... > comment about Patch4 but no Patch4 ... cleanup neeeded? This comment is about Patch0 - fixed. > > I see only AUTHORS COPYING and README - why you don't use %doc macro for them? > It would give user a chance to install rpm without documentation. Fixed. > > .c/.h files in srpm have strange permissions 755. Have you considered -devel > subpackage? Or it is not expected someone except IBM could use the API for > development? -devel subpackage is not necessary. No .c/.h files are shipped. In case that someone will need -devel subpackage, I'll create it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
