https://bugzilla.redhat.com/show_bug.cgi?id=2118080
Dan Horák <d...@danny.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Environment| |If this bug requires
| |documentation, please
| |select an appropriate Doc
| |Type value.
Assignee|nob...@fedoraproject.org |d...@danny.cz
Flags| |fedora-review+
--- Comment #4 from Dan Horák <d...@danny.cz> ---
formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
e910c6549ef7ffd6a209aac26724c6d14404e094
nativefiledialog-extended-1.0.0.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK package builds in mock (Rawhide/ppc64le).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A* %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
Ok file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel subpackage
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- rpmlint complains about missing documentation in devel, but the README in
main pkg is sufficient
- some packages use a trick with Xvfb to run graphical tests
- the soname (library version) should be handled more safely, eg. with
%{_libdir}/libnfd.so.1 instead of the wildcards, also would be good to know
about the ABI stability and versioning plans from upstream
The package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2118080
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
