https://bugzilla.redhat.com/show_bug.cgi?id=2119983
Jonathan Wright <jonat...@almalinux.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
| |needinfo?(negativo17@gmail.
| |com)
Doc Type|--- |If docs needed, set a value
CC| |jonat...@almalinux.org
Assignee|nob...@fedoraproject.org |jonat...@almalinux.org
--- Comment #1 from Jonathan Wright <jonat...@almalinux.org> ---
> Summary: An implementation of an ICAP server
> Name: c-icap
Generally speaking it's best to put the `Name` at the top of the file below
only global macros/overrides. I'm not sure if there's documentation citing
this so consider it a suggested best practice at minimum.
> License: LGPLv2+
Licenses should be in SPDX format now. [1]
> Source0:
> http://downloads.sourceforge.net/project/%{name}/%{name}/0.5.x/c_icap-%{version}.tar.gz
Personally I'd use GitHub for the source URL here, mainly due to the "0.5.x"
part of the URL which will require updating in the future whereas a GH URL can
use all variables.
https://github.com/c-icap/c-icap-server/archive/C_ICAP_%{version}/c_icap-%{version}.tar.gz
> %doc AUTHORS COPYING README TODO
`COPYING` should not be under `%doc` but on its own line: `%license COPYING`
[2]
> %config(noreplace) %{_tmpfilesdir}/%{name}.conf
Config files cannot go in /usr. [3]
> BuildRequires: libdb-devel
This package is deprecated so you cannot depend on it. [4]
> %package perl
> Summary: The Perl handler for %{name}
> Requires: %{name} = %{version}-%{release}
Since this is an architecture-specific compiled lib you need to match the full
version including arch. It's always better to overstate the version anyway.
[5] ie:
Requires: %{name}%{?_isa} = %{version}-%{release}
Same for the ldap sub-package.
---
The old changelog from other folks is probably not needed. The %changelog
section is really to show a package's history in Fedora to represent potential
user-impacting changes so anything before it became a package isn't really
relevant. [6]
1.
https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names
2. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation
3. https://docs.fedoraproject.org/en-US/packaging-
guidelines/#_configuration_files
4.
https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/#_consequences_of_a_package_being_deprecated
5.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
6. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2119983
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
