https://bugzilla.redhat.com/show_bug.cgi?id=2076836
--- Comment #2 from Gustavo Costa <xfgu...@gmail.com> --- Hi Jakub. I hope you're doing well. Sorry for the late reply, I was away from my computer for a few weeks. > I also found a BSD license in inc/stack.h so we should probably > mention that in the comment as well. This header file is also part of the "shunting-yard code" and it's by the same author. That's why I decided to not make a license breakdown like this: inc/shunting-yard.h inc/stack.c src/shunting-yard.c src/stack.c tests/test-shunting-yard.c > Looking at the license, I think it is GPLv3, not GPLv3+ . Do you > agree? Maybe I am misreading it. You're right. I fixed it and also updated the license identifiers to use SPDX. > There is also LICENSE so we should IMHO install both of them Both files have the same content. I think it's fine to just install one of them. $ diff --report-identical-files COPYING LICENSE Files COPYING and LICENSE are identical > TIL that there is this pkgconfig macro, thanks :-) It's a nice feature. It's also possible to use this with dnf install/remove. $ dnf install 'pkgconfig(cunit)' Thanks for the quick review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2076836 _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
