https://bugzilla.redhat.com/show_bug.cgi?id=2132022



--- Comment #2 from Tomáš Hrnčiar <thrnc...@redhat.com> ---
(In reply to Miro Hrončok from comment #1)
> > BuildRequires:  pytest
> 
> I'd use python3-pytest here, for consistency.
> 

done

> 
> > BuildRequires:  pre-commit
> > BuildRequires:  python3-mypy
> 
> Is it possible to test without those?
> 

Yes, I have removed them.

> 
> 
> I see this BuildRequires poetry:
> 
> $ rpm -qRp python-poetry-plugin-export-1.1.1-1.fc38.src.rpm 
> (python3dist(poetry) < 2~~ with python3dist(poetry) >= 1.2)
> (python3dist(poetry-core) < 2~~ with python3dist(poetry-core) >= 1.1)
> ...
> 
> Should it have a tests bconds that adds -R to %pyproject_buildrequires, to
> avoid a bootstrap loop?

I've added it in the latest version of specfile. See below.

Spec URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/04887892-python-poetry-plugin-export/python-poetry-plugin-export.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/thrnciar/poetry/fedora-rawhide-x86_64/04887892-python-poetry-plugin-export/python-poetry-plugin-export-1.1.1-1.fc38.src.rpm
Description: This package is a plugin that allows the export of locked packages
to various formats. This plugin provides the same features as the existing
export command of Poetry which it will eventually replace.
Fedora Account System Username:thrnciar


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132022
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to